refactor: simplify iterator using cloned().map(Some) - #9449
Merged
Merged
Conversation
scovich
approved these changes
Feb 22, 2026
scovich
left a comment
scovich
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Just a cosmetic change? or does it impact performance in some way?
Contributor
Author
This is an idiomatic Rust refactor and has no performance impact. |
scovich
approved these changes
Feb 23, 2026
scovich
left a comment
scovich
left a comment
Contributor
There was a problem hiding this comment.
Umm... it had my approval stamp until you cleared it by requesting a new review?
Contributor
|
But since this is a pretty safe change and nobody else squawked, will go ahead and merge also. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Use .cloned().map(Some) instead of .map(|b| Some(b.clone()))
for better readability and idiomatic Rust style.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?