chore: Fix audit CI run by ignore quick-xml audit advisories - #10267
Merged
Conversation
This was referenced Jul 2, 2026
alamb
marked this pull request as ready for review
July 2, 2026 13:24
alamb
changed the title
Jefffrey
approved these changes
Jul 2, 2026
alamb
commented
Jul 2, 2026
| run: cargo install cargo-audit --locked | ||
| - name: Run audit check | ||
| run: cargo audit | ||
| # Waiting on an object_store release with quick-xml >=0.41.0. |
Contributor
Author
There was a problem hiding this comment.
these are about DOS attacks parsing untrusted XML . -1 for rustsec advisories but 🤷
This was referenced Jul 2, 2026
Phoenix500526
pushed a commit
to Phoenix500526/datafusion
that referenced
this pull request
Jul 3, 2026
## Which issue does this PR close? - Closes apache#23297. ## Rationale for this change The audit workflow is failing on main due to the quick-xml advisories: - RUSTSEC-2026-0194 - RUSTSEC-2026-0195 quick-xml is pulled in transitively through object_store, and the released object_store version currently used by DataFusion does not yet depend on quick-xml >= 0.41.0. ## What changes are included in this PR? This temporarily ignores the two quick-xml RustSec advisories in the audit workflow and documents that the ignores should be removed once object_store upgrades to quick-xml >= 0.41.0. This is what I did in arrow-rs as well - apache/arrow-rs#10267 ## Are these changes tested? By CI ## Are there any user-facing changes? No.
alamb
added a commit
that referenced
this pull request
Jul 18, 2026
# Which issue does this PR close? - part of #10349 # Rationale for this change Get a clean CI # What changes are included in this PR? Backport / Cherry-pick: - #10170 - #10267 # Are these changes tested? By CI # Are there any user-facing changes? No --------- Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
The audit workflow is failing on main: https://github.com/apache/arrow-rs/actions/runs/28591575622/job/84776210875
Run cargo audit Fetching advisory database from `[https://github.com/RustSec/advisory-db.git`](https://github.com/RustSec/advisory-db.git%60) Loaded 1149 security advisories (from /home/runner/.cargo/advisory-db) Updating crates.io index Scanning Cargo.lock for vulnerabilities (447 crate dependencies) Crate: quick-xml Version: 0.39.4 Title: Quadratic run time when checking a start tag for duplicate attribute names Date: 2026-06-29 ID: RUSTSEC-2026-0194 URL: https://rustsec.org/advisories/RUSTSEC-2026-0194 Severity: 7.5 (high) Solution: Upgrade to >=0.41.0 Crate: quick-xml error: 2 vulnerabilities found! warning: 1 allowed warning found Version: 0.39.4 Title: Unbounded namespace-declaration allocation in `NsReader` enables memory-exhaustion denial of service Date: 2026-06-29 ID: RUSTSEC-2026-0195 URL: https://rustsec.org/advisories/RUSTSEC-2026-0195 Severity: 7.5 (high) Solution: Upgrade to >=0.41.0 Crate: paste Version: 1.0.15 Warning: unmaintained Title: paste - no longer maintained Date: 2024-10-07 ID: RUSTSEC-2024-0436 URL: https://rustsec.org/advisories/RUSTSEC-2024-0436 Error: Process completed with exit code 1.quick-xml advisories RUSTSEC-2026-0194 and RUSTSEC-2026-0195. quick-xml is pulled in transitively through object_store, and the released object_store versions available to arrow-rs do not yet depend on quick-xml >=0.41.0.
What changes are included in this PR?
This temporarily ignores the two quick-xml RustSec advisories in the audit workflow and documents the upstream dependency release needed to remove the ignore.
Are there any user-facing changes?
No.
Validation
Inspected the failing GitHub Actions audit job and verified the dependency path with cargo tree.