Replace conversion of binary->string in arrow-row from arraydata to direct construction - #10261
Conversation
…irect construction
af3bc6c to
08c57a3
Compare
|
run benchmark row_format |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing replace-array-data-row (08c57a3) to 32bba5a (merge-base) diff File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
Thanks @Jefffrey |
Which issue does this PR close?
ArrayDatawith direct Array construction, when possible #9298Rationale for this change
Missed by #10229 as it used the
into_data()API (I was grepping just forArrayData). Instead of roundtripping through arraydata to convert from a binary to string, just directly useinto_parts()andnew_unchecked()for optimization.What changes are included in this PR?
Remove arraydata roundtrip in favour of deconstructing with
into_parts()and constructing withnew_unchecked()Are these changes tested?
Existing tests
Are there any user-facing changes?
No