Repository navigation
fix: restore 1.85 MSRV and fix MSRV CI - #812
Merged
Merged
Conversation
Contributor
|
I also get this compilation error on 1.85: It's in a test, so not a big deal |
Contributor
|
Thank you @LDeakin |
Contributor
I think the error is that the tests are not included in We need to add the |
This was referenced Aug 17, 2026
Contributor
|
We need to add the --all-targets to have the tests included too. I will make a PR to do this I also made another PR to speed up this CI check: |
kylebarron
pushed a commit
that referenced
this pull request
Aug 20, 2026
…CI (#837) str::from_utf8 (as an associated function on the str primitive) was only stabilized in Rust 1.87, but the crate's MSRV is 1.85. The MSRV CI job did not catch this because cargo-msrv's default check command (cargo check) does not compile test code. Use a custom cargo-msrv check command with --all-targets so tests, examples, and benches are also verified against the MSRV. Reported in #812 (comment) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just avoids using let chains, which were introduced in 1.88 or something.