Skip to content

fix propagation of maxdepth kwarg - #181

Merged
quinnj merged 2 commits into
mainfrom
jr/maxdepth
Apr 23, 2021
Merged

fix propagation of maxdepth kwarg#181
quinnj merged 2 commits into
mainfrom
jr/maxdepth

Conversation

@jrevels

@jrevels jrevels commented Apr 22, 2021

Copy link
Copy Markdown
Contributor

fixes #180

@jrevels
jrevels requested a review from quinnj April 22, 2021 03:21
@codecov

codecov Bot commented Apr 22, 2021

Copy link
Copy Markdown

Codecov Report

Merging #181 (47942c3) into main (1af27ba) will increase coverage by 0.09%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   81.34%   81.44%   +0.09%     
==========================================
  Files          25       25              
  Lines        3034     3034              
==========================================
+ Hits         2468     2471       +3     
+ Misses        566      563       -3     
Impacted Files Coverage Δ
src/write.jl 95.69% <ø> (ø)
src/arraytypes/arraytypes.jl 87.87% <50.00%> (+1.01%) ⬆️
src/ArrowTypes/src/ArrowTypes.jl 97.95% <0.00%> (+0.68%) ⬆️
src/arraytypes/map.jl 98.48% <0.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af27ba...47942c3. Read the comment docs.

@quinnj quinnj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; thanks!

@quinnj
quinnj merged commit 125c1e7 into main Apr 23, 2021
@quinnj
quinnj deleted the jr/maxdepth branch April 23, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

maxdepth argument not fully forwarded to inner functions from Arrow.write?

2 participants