ability to append partitions to existing arrow files - #160
Merged
Conversation
Contributor
Author
|
Also ref #105 which seems related. |
Codecov Report
@@ Coverage Diff @@
## main #160 +/- ##
==========================================
+ Coverage 81.32% 81.94% +0.62%
==========================================
Files 25 26 +1
Lines 3015 3119 +104
==========================================
+ Hits 2452 2556 +104
Misses 563 563
Continue to review full report at Codecov.
|
quinnj
reviewed
Apr 1, 2021
tanmaykm
force-pushed
the
tan/append
branch
2 times, most recently
from
April 7, 2021 08:51
57d13c6 to
ce68fd0
Compare
This adds a method to `append` partitions to existing arrow files. Partitiions to append to are supplied in the form of any [Tables.jl](https://github.com/JuliaData/Tables.jl)-compatible table. Multiple record batches will be written based on the number of `Tables.partitions(tbl)` that are provided. Each partition being appended must have the same `Tables.Schema` as the destination arrow file that is being appended to. Other parameters that `append` accepts are similar to what `write` accepts.
Contributor
Author
|
Hi @quinnj, does this look okay, or is anything more needed here? |
Member
|
Sorry, I've been trying to catch up on a bunch of stuff since coming back from vacation; planning on reviewing this more in-depth in the next 24 hours. |
quinnj
reviewed
Apr 14, 2021
store few additional stream properties in the `Stream` data type and avoid duplicating code for append functionality
Contributor
Author
|
@quinnj I have now added commits to allow appends to |
Contributor
Author
|
bump! |
This was referenced Jan 12, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a method to
appendpartitions to existing arrow files. Partitiions to append to are supplied in the form of any Tables.jl-compatible table.Multiple record batches will be written based on the number of
Tables.partitions(tbl)that are provided.Each partition being appended must have the same
Tables.Schemaas the destination arrow file that is being appended to.Other parameters that
appendaccepts are similar to whatwriteaccepts.