Skip to content

Keep task log selection stable while dragging - #71155

Merged
bbovenzi merged 4 commits into
apache:mainfrom
Andrushika:fix-log-viewer-selection-drag
Aug 10, 2026
Merged

Keep task log selection stable while dragging#71155
bbovenzi merged 4 commits into
apache:mainfrom
Andrushika:fix-log-viewer-selection-drag

Conversation

@Andrushika

@Andrushika Andrushika commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Why

The log viewer virtualizes rows and positions each mounted row absolutely. (position: absolute)
When a downward drag passes the last mounted row, including trailing space inside the viewer, Chrome can move the selection focus to the start of the virtualized block. The selection then reverses instead of following autoscroll.

2026-08-06.7.42.03.mov

What

Use the earlier of the viewer bottom and the last mounted row bottom as the downward drag boundary, then keep the focus on the last mounted row while a left-button drag stays past it. Pointer, selection, and scroll events share one pending animation frame. Upward selection stays native.

2026-08-06.9.43.08.mov

related: #68846, #71148


Was generative AI tooling used to co-author this PR?
  • Yes — Codex (GPT-5)

Generated-by: Codex (GPT-5) following the guidelines

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Aug 5, 2026
Chrome can resolve the drag focus to the start of the absolutely positioned virtualized log block when the pointer moves below the viewport, reversing the selection.
@Andrushika
Andrushika force-pushed the fix-log-viewer-selection-drag branch from 10d752e to 97e5aaf Compare August 6, 2026 12:31
@Andrushika

Copy link
Copy Markdown
Contributor Author

Close and open PR again to re-trigger CI.

@Andrushika Andrushika closed this Aug 6, 2026
@Andrushika Andrushika reopened this Aug 6, 2026
@bbovenzi bbovenzi added this to the Airflow 3.3.2 milestone Aug 10, 2026
@bbovenzi bbovenzi added the backport-to-v3-3-test Backport to v3-3-test label Aug 10, 2026
@bbovenzi
bbovenzi merged commit 643a0fa into apache:main Aug 10, 2026
88 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-3-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 643a0fa v3-3-test

This should apply the commit to the v3-3-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

dabla pushed a commit to dabla/airflow that referenced this pull request Aug 14, 2026
* Keep downward task log selection stable while dragging

Chrome can resolve the drag focus to the start of the absolutely positioned virtualized log block when the pointer moves below the viewport, reversing the selection.

* Keep task log selection stable while dragging

* Fix duplicate imports left over from merge conflict resolution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-3-test Backport to v3-3-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants