[v3-3-test] Stop auto-scrolling task logs while the user is selecting text (#70594) - #71127
Merged
Conversation
… text (#70594) * Follow live task logs only when at the very end When a task is running, the log view follows new lines by auto-scrolling to the bottom. It kept following even when the user had scrolled up a little to read something, because "at the bottom" allowed a 100px gap. Lower the gap so scrolling up stops the follow, and returning to the end resumes it. * Pause the task log auto-scroll while the user is selecting text While a task streams logs, the view follows new lines by scrolling to the bottom. If the user is selecting text at the bottom, the scroll moves the text out from under the cursor and clears the selection. Skip the follow while a non-empty selection sits inside the log; clearing it resumes. (cherry picked from commit 9d4245a) Co-authored-by: Andrew Chang <69671930+Andrushika@users.noreply.github.com>
1 task
bbovenzi
marked this pull request as ready for review
August 4, 2026 20:57
bbovenzi
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
August 4, 2026 20:57
vatsrahul1001
added a commit
that referenced
this pull request
Aug 5, 2026
… text (#70594) (#71127) * Follow live task logs only when at the very end When a task is running, the log view follows new lines by auto-scrolling to the bottom. It kept following even when the user had scrolled up a little to read something, because "at the bottom" allowed a 100px gap. Lower the gap so scrolling up stops the follow, and returning to the end resumes it. * Pause the task log auto-scroll while the user is selecting text While a task streams logs, the view follows new lines by scrolling to the bottom. If the user is selecting text at the bottom, the scroll moves the text out from under the cursor and clears the selection. Skip the follow while a non-empty selection sits inside the log; clearing it resumes. (cherry picked from commit 9d4245a) Co-authored-by: Andrew Chang <69671930+Andrushika@users.noreply.github.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a task is running, the log view follows new lines by auto-scrolling to
the bottom. It kept following even when the user had scrolled up a little to
read something, because "at the bottom" allowed a 100px gap. Lower the gap so
scrolling up stops the follow, and returning to the end resumes it.
While a task streams logs, the view follows new lines by scrolling to the
bottom. If the user is selecting text at the bottom, the scroll moves the
text out from under the cursor and clears the selection. Skip the follow
while a non-empty selection sits inside the log; clearing it resumes.
(cherry picked from commit 9d4245a)
Co-authored-by: Andrew Chang 69671930+Andrushika@users.noreply.github.com