Support Monaco Editor 0.56 public exports - #70937
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Monaco 0.56 enforces its package exports, so private deep imports prevent the UI from linting and building after the dependency upgrade.
3dd2332 to
7ca4d2a
Compare
bbovenzi
left a comment
There was a problem hiding this comment.
Let's please give this some manual testing to make sure we are importing everything correctly.
- what does it look like when the Monaco Editor is loading?
- does error highlighting show up when adding invalid json to the trigger dag -> advanced form?
- Does python code in the dag code tab render correctly?
|
Verified the follow-up in commit 408cbd8 on WSL2:
The full UI suite consistently reaches 103-104 passing test files before a Vitest worker exits with a Node 22/libuv |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* UI: Support Monaco Editor 0.56 Monaco 0.56 enforces its package exports, so private deep imports prevent the UI from linting and building after the dependency upgrade. * UI: Register Monaco editor feature services --------- Co-authored-by: szzhoujiarui <311234381+szzhoujiarui@users.noreply.github.com>
Upgrade Monaco Editor to 0.56 and replace private
esm/vsimports with the package's public exports.Register folding, find, codicon, and JSON features through public entry points. Retain Airflow's explicit registration of its patched Python grammar so f-string tokenization remains intact.
This keeps Monaco workers and language features compatible with 0.56 and avoids private module paths that no longer resolve in Vite.
closes: #70929
Testing
CI=true corepack pnpm@10.25.0 install --frozen-lockfilecorepack pnpm@10.25.0 test— 102 files and 777 tests passedcorepack pnpm@10.25.0 exec vitest run src/components/MonacoEditor/pythonFStrings.test.ts— 12 tests passedcorepack pnpm@10.25.0 lintcorepack pnpm@10.25.0 buildbreeze ci selective-check --commit-ref 421c0c9breeze testing ui-e2e-tests --test-pattern "dag-code-tab.spec.ts" --workers 1— blocked during environment checks because Docker is unavailable in the current environmentWas generative AI tooling used to co-author this PR?
Generated-by: MonkeyCode (GPT-5.6 Sol) following the guidelines
Drafted-by: MonkeyCode (GPT-5.6 Sol); reviewed by @szzhoujiarui before posting