UI: Add button to find run on Grid from run header - #70803
UI: Add button to find run on Grid from run header#70803suhaas-vaddadi wants to merge 6 commits into
Conversation
boring-cyborg
Bot
added
area:translations
area:UI
dheerajturaga
left a comment
dheerajturaga
left a comment
There was a problem hiding this comment.
I feel the name is too long? I think we can shorten it
|
@suhaas-vaddadi, Can you update the description with the changes made? |
Should be now up to date! |
|
@suhaas-vaddadi, can you also fix the CI? |
There was a problem hiding this comment.
@suhaas-vaddadi, This works as expected. I feel for completeness, it would be great if this were extended to the task instances as well?
43aa9ce to
798d9ee
Compare
dheerajturaga
left a comment
dheerajturaga
left a comment
There was a problem hiding this comment.
Awesome! works as expected. Would like another pair of eyes from UI experts. Good to merge if CI passes
Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Match the ghost styling of the other run-header icon buttons.
51519a5 to
532c981
Compare
|
Clicking "Show in Grid" in the run or task-instance header only sets the run_id_pattern filter, but the left panel keeps showing whichever view is active (Graph/Gantt), so from those views the button appears to do nothing. Maybe, have the action also switch the panel to Grid so the filtered run is actually visible after the click. |
|
Wait if we're on a run, then the grid should paginate over to show the run. if that is broken then we should fix the route cause not add another button |
This is not happening today. If there are more than 50+ runs for example (UI limits to 50), the dag run doesn't show in the grid view |
| <IconButton label={translate("dagRun.showInGrid")} onClick={showInGrid}> | ||
| <LuScanSearch /> | ||
| </IconButton> |
There was a problem hiding this comment.
Also, if we even do this then let's make this its own component. No need to copy past the exact logic.
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
The actually functionality is "Filter this run" and remove all other runs in the grid view. In that case, we should move it inside the grid view instead of the header and make it a "Quick Filter" option.
shubhamraj-git
left a comment
shubhamraj-git
left a comment
There was a problem hiding this comment.
Added comment above, missed to make it part of review.
There was a problem hiding this comment.
Wait if we're on a run, then the grid should paginate over to show the run. if that is broken then we should fix the route cause not add another button
Brent is right.
This is not happening today. If there are more than 50+ runs for example (UI limits to 50), the dag run doesn't show in the grid view
I think we need to fix that then. This button doesn't really make sense for me:
- Either we clicked through the grid, and we have the run/task already selected.
- Either we landed here through a link, and the grid should be focus around that run, with that run selected. This was fixed in the past I believe, we shouldn't have a grid where the selected run is actually outside the grid window. (makes it impossible to navigate history and runs after/before that specific run / task)
5 participants
Button Placement and Icon
Run View
Task View
Effect of Pressing Button
Adds a "Show in Grid View" button to the DagRun header. Clicking it filters the Grid view down to the current run. This functions even past the window of 50 runs normally visible on the grid view.
The button writes the current
dag_run_idinto therun_id_patternURL search param. The Details/Grid layout already reads that same param, so the co-rendered Grid immediately filters to this run. This reuses the existing search-param filtering convention — no new API calls, just a URL-state update.Reuses functionality added from PR #70150
Note:
run_id_patternis a substring filter, not an exact match. The button sets it to the full run ID, so the target run always matches. If another run's ID happened to contain this one as a substring, both would appear.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.