Skip to content

UI: Align boolean controls in Trigger Dag form - #70713

Merged
vatsrahul1001 merged 3 commits into
apache:mainfrom
shivaam:fix-67852-trigger-dag-param-layout
Aug 3, 2026
Merged

UI: Align boolean controls in Trigger Dag form#70713
vatsrahul1001 merged 3 commits into
apache:mainfrom
shivaam:fix-67852-trigger-dag-param-layout

Conversation

@shivaam

@shivaam shivaam commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Align boolean parameter switches with the right edge of the existing control
column in the Trigger Dag form.

The form already reserves 30% of each row for the label and 70% for the
control. Boolean switches are intrinsically sized, so they remained at the
left edge of the control column while text fields and other full-width
controls extended to its right edge. Making the switch root fill the control
column and aligning its control to the end restores consistent scanability
without changing the established row layout or long-label wrapping.

A focused component test covers both style properties required for the
alignment.

Closes: #67852

Screenshots

Before

trigger-dag-before

After

trigger-dag-after

Testing

  • Focused Vitest for FieldBool.test.tsx
  • Full UI TypeScript check
  • UI ESLint and Prettier checks
  • Airflow prek checks for the changed files
  • Real Trigger Dag modal validation at desktop and 480 px viewport
  • Comprehensive Params example Dag with all parameter sections expanded

Was generative AI tooling used to co-author this PR?
  • Yes — Codex (GPT-5)

Generated-by: Codex (GPT-5) following the guidelines

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Jul 30, 2026
@shivaam
shivaam force-pushed the fix-67852-trigger-dag-param-layout branch from 0242d1b to fdd5b7a Compare July 30, 2026 05:07
@shivaam
shivaam marked this pull request as ready for review July 30, 2026 05:44
@bbovenzi bbovenzi added this to the Airflow 3.3.1 milestone Jul 31, 2026
@bbovenzi bbovenzi added the backport-to-v3-3-test Backport to v3-3-test label Jul 31, 2026
Comment thread airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldBool.test.tsx Outdated
@vatsrahul1001
vatsrahul1001 merged commit 6fb2c61 into apache:main Aug 3, 2026
89 checks passed
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test PR Link

eladkal pushed a commit that referenced this pull request Aug 3, 2026
…70963)

* UI: Align boolean controls in Trigger Dag form

* Remove layout-specific FieldBool test
(cherry picked from commit 6fb2c61)

Co-authored-by: Shivam Rastogi <6463385+shivaam@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Aug 5, 2026
…70963)

* UI: Align boolean controls in Trigger Dag form

* Remove layout-specific FieldBool test
(cherry picked from commit 6fb2c61)

Co-authored-by: Shivam Rastogi <6463385+shivaam@users.noreply.github.com>
dabla pushed a commit to dabla/airflow that referenced this pull request Aug 14, 2026
* UI: Align boolean controls in Trigger Dag form

* Remove layout-specific FieldBool test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-3-test Backport to v3-3-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trigger DAG modal: two-column layout for params (label left, control right)

3 participants