Skip to content

Fix incorrect code samples in the Deadline Alerts docs - #70709

Merged
ferruzzi merged 1 commit into
apache:mainfrom
aws-mwaa:ferruzzi/deadline-reference/docs-corrections
Jul 30, 2026
Merged

Fix incorrect code samples in the Deadline Alerts docs#70709
ferruzzi merged 1 commit into
apache:mainfrom
aws-mwaa:ferruzzi/deadline-reference/docs-corrections

Conversation

@ferruzzi

Copy link
Copy Markdown
Contributor

The custom reference usage example called the registered reference, which raises a TypeError since registration stores an instance. The required_kwargs example declared a kwarg that Airflow never supplies, so it raised a ValueError on every evaluation. Also removed a leftover editorial placeholder.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@seanghaeli seanghaeli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This raises a potential improvement item for later whereby the user can specify arbitrary Dag evaluation-time context outside of dag_id/run_id

@vatsrahul1001 vatsrahul1001 added the backport-to-v3-3-test Backport to v3-3-test label Jul 30, 2026
@ferruzzi
ferruzzi merged commit 9f88779 into apache:main Jul 30, 2026
70 checks passed
@ferruzzi
ferruzzi deleted the ferruzzi/deadline-reference/docs-corrections branch July 30, 2026 17:29
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test PR Link

github-actions Bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jul 30, 2026
…pache#70709)

(cherry picked from commit 9f88779)

Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jul 30, 2026
…pache#70709)

(cherry picked from commit 9f88779)

Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
vatsrahul1001 pushed a commit that referenced this pull request Jul 31, 2026
…70709) (#70786)

(cherry picked from commit 9f88779)

Co-authored-by: D. Ferruzzi <ferruzzi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants