[v3-3-test] Fix triggerer CrashLoopBackOff when json_logs is enabled (#68584) - #70669
Merged
Conversation
…68584) * Fix triggerer CrashLoopBackOff when json_logs is enabled TriggerRunnerSupervisor._process_log_messages_from_subprocess primes itself by calling airflow.sdk.log.configure_logging() with no arguments. json_output defaults to False, so this reconfigures structlog globally and installs the text WriteLogger factory -- overwriting the bytes BytesLogger factory that startup set up from json_logs=True. The stdout/stderr forwarders (_create_log_forwarder -> forward_to_log) were already wrapped with the JSON (bytes) processor chain but bind their underlying logger lazily. As soon as a trigger subprocess writes to stdout/stderr -- for example an import-time warning from a provider trigger that pulls in a heavy client (kubernetes, boto3) -- the lazy bind resolves against the now-text factory and WriteLogger.msg does `message + "\n"` on bytes from the JSON renderer, raising `TypeError: can't concat str to bytes` and crash-looping the triggerer. Pass json_output from the logging.json_logs config so the global structlog factory stays consistent with the rest of the process. * Add newsfragment * Refactor docstring for test_process_log_messages_configures_logging Updated the docstring to clarify the behavior of `_process_log_messages_from_subprocess()` regarding JSON logging configuration. * Delete airflow-core/newsfragments/68584.bugfix.rst * Remove comments about logging configuration Removed comments explaining the configure_logging function's behavior with json_logs setting. (cherry picked from commit ebe6c58) Co-authored-by: safaehar <safae.hariri@datadoghq.com>
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TriggerRunnerSupervisor._process_log_messages_from_subprocess primes itself
by calling airflow.sdk.log.configure_logging() with no arguments. json_output
defaults to False, so this reconfigures structlog globally and installs the
text WriteLogger factory -- overwriting the bytes BytesLogger factory that
startup set up from json_logs=True.
The stdout/stderr forwarders (_create_log_forwarder -> forward_to_log) were
already wrapped with the JSON (bytes) processor chain but bind their underlying
logger lazily. As soon as a trigger subprocess writes to stdout/stderr -- for
example an import-time warning from a provider trigger that pulls in a heavy
client (kubernetes, boto3) -- the lazy bind resolves against the now-text
factory and WriteLogger.msg does
message + "\n"on bytes from the JSONrenderer, raising
TypeError: can't concat str to bytesand crash-looping thetriggerer.
Pass json_output from the logging.json_logs config so the global structlog
factory stays consistent with the rest of the process.
Add newsfragment
Refactor docstring for test_process_log_messages_configures_logging
Updated the docstring to clarify the behavior of
_process_log_messages_from_subprocess()regarding JSON logging configuration.Delete airflow-core/newsfragments/68584.bugfix.rst
Remove comments about logging configuration
Removed comments explaining the configure_logging function's behavior with json_logs setting.
(cherry picked from commit ebe6c58)
Co-authored-by: safaehar safae.hariri@datadoghq.com