[v3-3-test] Speed up Trigger.clean_unused query to prevent Triggerer crashes (#68244) - #70668
Merged
Conversation
…crashes (#68244) * Use NOT EXISTS anti-join in Trigger.clean_unused instead of LEFT JOIN + aggregate * add FOR UPDATE SKIP LOCKED to Trigger.clean_unused to avoid deadlocks between concurrent triggerer pods * use with_row_locks helper and scope lock to trigger table (cherry picked from commit 2c1035a) Co-authored-by: AntonioBergonzi <48454032+AntonioBergonzi@users.noreply.github.com>
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
vatsrahul1001
added a commit
that referenced
this pull request
Aug 5, 2026
…crashes (#68244) (#70668) * Use NOT EXISTS anti-join in Trigger.clean_unused instead of LEFT JOIN + aggregate * add FOR UPDATE SKIP LOCKED to Trigger.clean_unused to avoid deadlocks between concurrent triggerer pods * use with_row_locks helper and scope lock to trigger table (cherry picked from commit 2c1035a) Co-authored-by: AntonioBergonzi <48454032+AntonioBergonzi@users.noreply.github.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use NOT EXISTS anti-join in Trigger.clean_unused instead of LEFT JOIN + aggregate
add FOR UPDATE SKIP LOCKED to Trigger.clean_unused to avoid deadlocks between concurrent triggerer pods
use with_row_locks helper and scope lock to trigger table
(cherry picked from commit 2c1035a)
Co-authored-by: AntonioBergonzi 48454032+AntonioBergonzi@users.noreply.github.com