[v3-3-test] Regenerate UI client and fix deadline alerts with no fixed interval (#70637) - #70659
Merged
Merged
Conversation
…d interval (#70637) The deadline-alert response now reports a null interval when the alert has no fixed number of seconds, but the committed TypeScript client still described it as a required number. That stale client hid a real type error in every component rendering the completion rule, so `ts-compile-lint-ui` fails on a clean checkout and blocks unrelated PRs. The null is wrong on screen today as well: dayjs humanizes it as "a few seconds", so such an alert claims the run must complete within a few seconds of its reference point. There is no duration to name there, so the rule now names the reference point alone. English is the source and fallback locale, so the wording is added there alone and the other locales fall back to it until translated. (cherry picked from commit 78b88db) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
boring-cyborg
Bot
added
area:translations
area:UI
1 task
shahar1
marked this pull request as ready for review
July 29, 2026 05:47
shahar1
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
July 29, 2026 05:47
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
vatsrahul1001
added
the
type:misc/internal
vatsrahul1001
pushed a commit
that referenced
this pull request
Aug 5, 2026
…d interval (#70637) (#70659) The deadline-alert response now reports a null interval when the alert has no fixed number of seconds, but the committed TypeScript client still described it as a required number. That stale client hid a real type error in every component rendering the completion rule, so `ts-compile-lint-ui` fails on a clean checkout and blocks unrelated PRs. The null is wrong on screen today as well: dayjs humanizes it as "a few seconds", so such an alert claims the run must complete within a few seconds of its reference point. There is no duration to name there, so the rule now names the reference point alone. English is the source and fallback locale, so the wording is added there alone and the other locales fall back to it until translated. (cherry picked from commit 78b88db) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deadline-alert response now reports a null interval when the alert
has no fixed number of seconds, but the committed TypeScript client
still described it as a required number. That stale client hid a real
type error in every component rendering the completion rule, so
ts-compile-lint-uifails on a clean checkout and blocks unrelated PRs.The null is wrong on screen today as well: dayjs humanizes it as "a few
seconds", so such an alert claims the run must complete within a few
seconds of its reference point. There is no duration to name there, so
the rule now names the reference point alone. English is the source and
fallback locale, so the wording is added there alone and the other
locales fall back to it until translated.
(cherry picked from commit 78b88db)
Co-authored-by: Shahar Epstein 60007259+shahar1@users.noreply.github.com