[v3-3-test] Remove no-op ServerResponseError re-raise blocks in airflowctl operations - #70460
Merged
Merged
Conversation
…ions (apache#70376) * Remove no-op ServerResponseError re-raise blocks in airflowctl operations Every operation wrapped its request in a try/except that caught ServerResponseError only to re-raise it unchanged. The error is already raised by the client's raise_on_4xx_5xx response hook, so these wrappers added no behavior and only obscured the request logic. Dropping them leaves the propagation semantics identical while making each operation a plain request/parse. * Update airflow-ctl/src/airflowctl/api/operations.py Co-authored-by: Henry Chen <henryhenry0512@gmail.com> * Update airflow-ctl/src/airflowctl/api/operations.py Co-authored-by: Henry Chen <henryhenry0512@gmail.com> * Update airflow-ctl/src/airflowctl/api/operations.py Co-authored-by: Henry Chen <henryhenry0512@gmail.com> --------- Co-authored-by: Henry Chen <henryhenry0512@gmail.com> (cherry picked from commit fba10d4)
henry3260
requested review from
bugraoz93,
dheerajturaga and
potiuk
as code owners
July 26, 2026 05:21
1 task
shahar1
approved these changes
Jul 26, 2026
Contributor
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit fba10d4)
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.