Fix BashOperator script detection after templating - #70369
Merged
potiuk merged 1 commit intoJul 30, 2026
Conversation
fat-catTW
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
July 24, 2026 09:01
boring-cyborg
Bot
added
area:dev-tools
area:providers
backport-to-v3-3-test
fat-catTW
force-pushed
the
fix-bashoperator-template-init-70296
branch
2 times, most recently
from
July 24, 2026 12:55
7bcc585 to
6a4d28a
Compare
shahar1
reviewed
Jul 24, 2026
shahar1
left a comment
shahar1
left a comment
Contributor
There was a problem hiding this comment.
Static checks currently fail
Contributor
Author
|
I'll fix it. Thanks for review. |
fat-catTW
force-pushed
the
fix-bashoperator-template-init-70296
branch
7 times, most recently
from
July 26, 2026 13:44
3309f91 to
aebda73
Compare
Contributor
|
Could you resolve conflict? |
Contributor
Author
|
Sure |
fat-catTW
force-pushed
the
fix-bashoperator-template-init-70296
branch
3 times, most recently
from
July 28, 2026 03:35
31d8355 to
3f2cf7f
Compare
henry3260
approved these changes
Jul 28, 2026
fat-catTW
force-pushed
the
fix-bashoperator-template-init-70296
branch
from
July 28, 2026 17:18
3f2cf7f to
2eb27a5
Compare
BashOperator template fields are rendered after construction, so script detection based on the raw constructor argument can choose the wrong execution path for templated commands.
fat-catTW
force-pushed
the
fix-bashoperator-template-init-70296
branch
from
July 29, 2026 05:56
2eb27a5 to
afd4ea3
Compare
1 task
Contributor
Author
|
potiuk
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
BashOperatorso inline/script command detection runs afterbash_commandhas been templated.This avoids choosing the wrong execution path when
bash_commandis a Jinja expression that renders to a.shor.bashscript name.related: #70296
Was generative AI tooling used to co-author this PR?
[X]Yes (please specify the tool below)Generated-by: [Codex] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.