[v3-3-test] Detect template-field logic in operator __init__ in prek check (#70297) - #70316
Closed
github-actions[bot] wants to merge 1 commit into
Closed
[v3-3-test] Detect template-field logic in operator __init__ in prek check (#70297)#70316github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
…check (#70297) Template fields are rendered after the constructor runs, so any validation or transformation applied to them in __init__ acts on the un-rendered Jinja expression — the bug class behind #69813, where SSHRemoteJobOperator validated a templated remote_base_dir at construction time and cleanup then failed for any custom base. The validate-operators-init hook only recognised top-level assignment statements, so validation calls, conditionals and transformations were invisible to it, and sensors, subscripted AwsBaseOperator[...] bases and aws_template_fields(...)-based classes were not covered at all. Pre-existing violations (83 classes) are exempted via a path::Class ratchet file so the rule is enforced on new code immediately; a fixing PR must remove its entry (stale entries fail the hook). Burn-down is tracked at #70296. (cherry picked from commit bb89adf) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template fields are rendered after the constructor runs, so any
validation or transformation applied to them in init acts on the
un-rendered Jinja expression — the bug class behind #69813, where
SSHRemoteJobOperator validated a templated remote_base_dir at
construction time and cleanup then failed for any custom base. The
validate-operators-init hook only recognised top-level assignment
statements, so validation calls, conditionals and transformations were
invisible to it, and sensors, subscripted AwsBaseOperator[...] bases and
aws_template_fields(...)-based classes were not covered at all.
Pre-existing violations (83 classes) are exempted via a path::Class
ratchet file so the rule is enforced on new code immediately; a fixing
PR must remove its entry (stale entries fail the hook). Burn-down is
tracked at #70296.
(cherry picked from commit bb89adf)
Co-authored-by: Shahar Epstein 60007259+shahar1@users.noreply.github.com