airflowctl: Fix datetime.datetime CLI parameter parsing - #70250
Draft
guptakushal03 wants to merge 1 commit into
Draft
airflowctl: Fix datetime.datetime CLI parameter parsing#70250guptakushal03 wants to merge 1 commit into
guptakushal03 wants to merge 1 commit into
Conversation
guptakushal03
requested review from
bugraoz93,
dheerajturaga,
henry3260 and
potiuk
as code owners
July 22, 2026 17:06
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
datetime.datetime-typed CLI parameter parsing inairflowctl.Previously,
datetime.datetimeparameters were mapped directly to thedatetime.datetimeconstructor, causing valid ISO-8601 datetime strings (for example,2026-07-01and2026-07-01T14:30:00) to be rejected byargparse.This change:
iso_datetime_type()to parse ISO-8601 datetime strings usingdatetime.datetime.fromisoformat().datetime.datetime-typed CLI arguments to use the parser instead of the bare constructor.argparse.ArgumentTypeError.closes: #70232
Was generative AI tooling used to co-author this PR?
Generated-by: ChatGPT following the guidelines.
Important
🛠️ Maintainer triage note for @guptakushal03 · by
@potiuk· 2026-08-13 12:55 UTCHelpful heads-up from the maintainers — please address before this PR can be reviewed:
Full list of what we check: Pull Request quality criteria.
The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.
Automated triage — may be imperfect; a maintainer takes the next look.