[v3-3-test] Fix partition key display and input handling (#69702) - #69974
Merged
Conversation
* UI: Fix partition key display and input handling Non-partitioned Dag runs showed a dangling "Partition key:" label, an empty partition key typed then cleared was sent to the trigger/materialize APIs and rejected with 400, the trigger form exposed the field even for non-partitioned Dags, the manual asset-event partition key used a JsonEditor for a plain string, and the runs table hid the partition_key column even when its filter was shown for a partitioned Dag. Also unify the partition key label so cron/runtime-partitioned runs no longer say "Mapped Partition key". * fixup! UI: Fix partition key display and input handling * fixup! fixup! UI: Fix partition key display and input handling * UI: Extract shared partition key normalization util The trigger form and manual/materialize asset-event flows each duplicated the same undefined/empty-string-to-null check before sending partition_key to the API, making the normalization easy to get subtly wrong in one call site while fixing it in another. * UI: Simplify partition key visibility check on asset event page Collapse the redundant undefined/null comparison into a single loose-equality null check, matching the reviewer's simplification of the earlier partition key display fix. * UI: Remove partition-key column auto-visibility from the runs table The runs table hid the partition_key column by default and revealed it only for partitioned Dags by fetching Dag details and forcing a table remount once the answer arrived. That remount-on-load approach was fragile, and the show/hide behaviour is better solved by a reusable mechanism (one that could also drive e.g. hiding map_index for non-mapped tasks), so it is dropped here to be reworked separately. (cherry picked from commit b767477) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
1 task
boring-cyborg
Bot
added
area:translations
area:UI
bbovenzi
approved these changes
Jul 16, 2026
bbovenzi
marked this pull request as ready for review
July 16, 2026 15:29
bbovenzi
requested review from
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
July 16, 2026 15:29
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-partitioned Dag runs showed a dangling "Partition key:" label, an
empty partition key typed then cleared was sent to the trigger/materialize
APIs and rejected with 400, the trigger form exposed the field even for
non-partitioned Dags, the manual asset-event partition key used a
JsonEditor for a plain string, and the runs table hid the partition_key
column even when its filter was shown for a partitioned Dag. Also unify
the partition key label so cron/runtime-partitioned runs no longer say
"Mapped Partition key".
fixup! UI: Fix partition key display and input handling
fixup! fixup! UI: Fix partition key display and input handling
UI: Extract shared partition key normalization util
The trigger form and manual/materialize asset-event flows each
duplicated the same undefined/empty-string-to-null check before
sending partition_key to the API, making the normalization easy to
get subtly wrong in one call site while fixing it in another.
Collapse the redundant undefined/null comparison into a single
loose-equality null check, matching the reviewer's simplification
of the earlier partition key display fix.
The runs table hid the partition_key column by default and revealed it
only for partitioned Dags by fetching Dag details and forcing a table
remount once the answer arrived. That remount-on-load approach was
fragile, and the show/hide behaviour is better solved by a reusable
mechanism (one that could also drive e.g. hiding map_index for
non-mapped tasks), so it is dropped here to be reworked separately.
(cherry picked from commit b767477)
Co-authored-by: Wei Lee weilee.rx@gmail.com