Skip to content

Remove airflow.utils dependency from Docker provider #69900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 2 commits into from
Jul 21, 2026
Merged

Remove airflow.utils dependency from Docker provider #69900

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb22cdc
Decouple Docker provider service naming from Airflow core
shaealh Jul 15, 2026
48afc69
Remove redundant Docker Swarm service name test
shaealh Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions providers/docker/src/airflow/providers/docker/operators/docker_swarm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@

from __future__ import annotations

import random
import re
import shlex
import string
from datetime import datetime
from time import sleep
from typing import TYPE_CHECKING, Literal
Expand All @@ -29,12 +31,17 @@

from airflow.providers.common.compat.sdk import AirflowException
from airflow.providers.docker.operators.docker import DockerOperator
from airflow.utils.strings import get_random_string

if TYPE_CHECKING:
from airflow.providers.common.compat.sdk import Context


def _generate_service_name(prefix: str) -> str:
"""Generate a unique Docker Swarm service name."""
suffix = "".join(random.choices(string.ascii_letters + string.digits, k=8))
return f"{prefix}-{suffix}"


class DockerSwarmOperator(DockerOperator):
"""
Execute a command as an ephemeral docker swarm service.
Expand Down Expand Up @@ -191,7 +198,7 @@ def _run_service(self) -> None:
placement=self.placement,
log_driver=self.log_driver_config,
),
name=f"{self.service_prefix}-{get_random_string()}",
name=_generate_service_name(self.service_prefix),
labels={"name": f"airflow__{self.dag_id}__{self.task_id}"},
mode=self.mode,
)
Expand Down