Skip to content

Allow multiple routes to show active NavButtons - #69884

Merged
bbovenzi merged 2 commits into
apache:mainfrom
astronomer:fix-active-nav-button
Jul 21, 2026
Merged

Allow multiple routes to show active NavButtons#69884
bbovenzi merged 2 commits into
apache:mainfrom
astronomer:fix-active-nav-button

Conversation

@bbovenzi

Copy link
Copy Markdown
Contributor

Update NavButton to show isActive for multiple routes. Such as all the children of menu buttons like Browse, Plugins and Admin. Or for Dags to stay active with the dag runs and task instance table pages.

Screenshot 2026-07-14 at 4 57 20 PM Screenshot 2026-07-14 at 4 57 12 PM
Was generative AI tooling used to co-author this PR?
  • Yes Claude Sonnet 5

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@bbovenzi bbovenzi added this to the Airflow 3.3.1 milestone Jul 14, 2026
@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Jul 14, 2026
@bbovenzi bbovenzi added the backport-to-v3-3-test Backport to v3-3-test label Jul 14, 2026

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet.

Working as expected, looks good.

Comment thread airflow-core/src/airflow/ui/src/layouts/Nav/SecurityButton.tsx Outdated
@bbovenzi
bbovenzi merged commit f3edf4d into apache:main Jul 21, 2026
89 checks passed
@bbovenzi
bbovenzi deleted the fix-active-nav-button branch July 21, 2026 17:53
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-3-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-3-test PR Link

pierrejeambrun pushed a commit that referenced this pull request Jul 27, 2026
…70200)

* Allow multiple routes to show active NavButtons

* clean up securitybutton
(cherry picked from commit f3edf4d)

Co-authored-by: Brent Bovenzi <brent@astronomer.io>
vatsrahul1001 pushed a commit that referenced this pull request Aug 5, 2026
…70200)

* Allow multiple routes to show active NavButtons

* clean up securitybutton
(cherry picked from commit f3edf4d)

Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-3-test Backport to v3-3-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants