Detect stale metrics registry entries in the metrics sync prek hook - #69578
Conversation
a8e4b57 to
544fd7f
Compare
6ccdd7c to
c0029d5
Compare
|
let's rebase from main and resolve the conflicts. thanks! |
c0029d5 to
a0ab7a3
Compare
Resolved it. Thanks. |
henry3260
left a comment
There was a problem hiding this comment.
Overall. looks good just 2 nits
Signed-off-by: PoAn Yang <payang@apache.org>
a0ab7a3 to
12c7e4a
Compare
Backport failed to create: v3-3-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker f44634c v3-3-testThis should apply the commit to the v3-3-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
Why
check-metrics-synced-with-registryonly checks one direction: a metric used in code but missing frommetrics_template.yaml.How
git ls-files). It checks any registry entry with no matching metric in code.INDIRECTLY_EMITTED_METRICSallowlist for the threeexecutor.*gauges whose names are built viaBaseExecutor._get_metric_name()and cannot be resolved statically.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.