Standardize Alembic migration descriptions and add a style lint - #69537
Conversation
|
When did this convention if creating our own ruff-style rule codes that aren't part of ruff come around? I'm not a huge fan of it, and I'm aware of any discussion about it. |
Rules https://docs.astral.sh/ruff/faq/#can-i-write-my-own-linter-plugins-for-ruff |
pierrejeambrun
left a comment
There was a problem hiding this comment.
LGTM, thanks.
Fair question from Ash, but outside the scope of this PR I suppose. (good potential follow up though)
c5c9ff9 to
119b2de
Compare
Signed-off-by: PoAn Yang <payang@apache.org>
119b2de to
58406de
Compare
Co-authored-by: Wei Lee <hello@wei-lee.me>
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
…e lint (apache#69537) (cherry picked from commit 54d9a8e) Co-authored-by: PoAn Yang <payang@apache.org> Co-authored-by: Wei Lee <hello@wei-lee.me> Signed-off-by: PoAn Yang <payang@apache.org>
…e lint (apache#69537) (cherry picked from commit 54d9a8e) Co-authored-by: PoAn Yang <payang@apache.org> Co-authored-by: Wei Lee <hello@wei-lee.me> Signed-off-by: PoAn Yang <payang@apache.org>
Why
migrations-ref.rstdocumentation table and printed byalembic history/airflow db migrate.Added ...,Adding ...), making those listings inconsistent.How
MIG004to thecheck-migration-patternsprek hook: the description must start with a capital letter, use the imperative mood, and end with a period.providers/*/migrations/versions/. fab and edge3 have their own migration trees and docs tables.migrations-ref.rstvia theupdate-migration-referenceshook.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.