Skip to content

Warn for bad combination of parameters for RedshiftDataOperator #69524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 1 commit into from
Jul 9, 2026
Merged

Warn for bad combination of parameters for RedshiftDataOperator #69524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions providers/amazon/src/airflow/providers/amazon/aws/operators/redshift_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,11 @@ def __init__(
self.deferrable = deferrable
self.session_id = session_id
self.session_keep_alive_seconds = session_keep_alive_seconds
if self.deferrable and not self.wait_for_completion:
Comment thread
amoghrajesh marked this conversation as resolved.
self.log.warning(
"deferrable=True and wait_for_completion=False are set; deferrable will be "
"ignored and this task will run non-deferrable."
)

def execute(self, context: Context) -> list[GetStatementResultResponseTypeDef] | list[str]:
"""Execute a statement against Amazon Redshift."""
Expand Down
15 changes: 15 additions & 0 deletions providers/amazon/tests/unit/amazon/aws/operators/test_redshift_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,21 @@ def test_init(self):
assert op.hook._verify is None
assert op.hook._config is None

@mock.patch.object(RedshiftDataOperator, "log", new_callable=mock.MagicMock)
def test_init_warns_when_deferrable_has_no_effect(self, mock_log):
"""deferrable=True is a no-op when wait_for_completion=False; the user should be told."""
RedshiftDataOperator(
task_id=TASK_ID,
database=DATABASE,
sql=SQL,
deferrable=True,
wait_for_completion=False,
)
mock_log.warning.assert_called_once_with(
"deferrable=True and wait_for_completion=False are set; deferrable will be "
"ignored and this task will run non-deferrable."
)

@mock.patch("airflow.providers.amazon.aws.hooks.redshift_data.RedshiftDataHook.execute_query")
@mock.patch("airflow.providers.amazon.aws.hooks.redshift_data.RedshiftDataHook.conn")
def test_execute(self, mock_conn, mock_exec_query):
Expand Down