UI: Load Monaco codicon glyph styles via direct CSS import - #69419
Merged
Conversation
monaco-editor 0.53 removed the `codiconStyles` side-effect module that the local ESM Monaco setup imported to register the codicon glyph font (the folding arrows and find-widget icons). Import the two stylesheets that module pulled in — `codicon/codicon.css` and `codicon/codicon-modifiers.css` — directly instead, mirroring the existing dynamic-CSS-import pattern already used for Katex. Both files ship in the currently pinned 0.52.2 and in newer releases, so this is behaviour-neutral today and lets the editor keep rendering its glyphs once monaco-editor is bumped past 0.52, unblocking the pending dependency update.
potiuk
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
July 5, 2026 21:06
shahar1
approved these changes
Jul 5, 2026
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
potiuk
added a commit
that referenced
this pull request
Jul 5, 2026
#69419) (#69422) monaco-editor 0.53 removed the `codiconStyles` side-effect module that the local ESM Monaco setup imported to register the codicon glyph font (the folding arrows and find-widget icons). Import the two stylesheets that module pulled in — `codicon/codicon.css` and `codicon/codicon-modifiers.css` — directly instead, mirroring the existing dynamic-CSS-import pattern already used for Katex. Both files ship in the currently pinned 0.52.2 and in newer releases, so this is behaviour-neutral today and lets the editor keep rendering its glyphs once monaco-editor is bumped past 0.52, unblocking the pending dependency update. (cherry picked from commit 2629cf3) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Jul 7, 2026
#69419) (#69422) monaco-editor 0.53 removed the `codiconStyles` side-effect module that the local ESM Monaco setup imported to register the codicon glyph font (the folding arrows and find-widget icons). Import the two stylesheets that module pulled in — `codicon/codicon.css` and `codicon/codicon-modifiers.css` — directly instead, mirroring the existing dynamic-CSS-import pattern already used for Katex. Both files ship in the currently pinned 0.52.2 and in newer releases, so this is behaviour-neutral today and lets the editor keep rendering its glyphs once monaco-editor is bumped past 0.52, unblocking the pending dependency update. (cherry picked from commit 2629cf3) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Jul 9, 2026
#69419) (#69422) monaco-editor 0.53 removed the `codiconStyles` side-effect module that the local ESM Monaco setup imported to register the codicon glyph font (the folding arrows and find-widget icons). Import the two stylesheets that module pulled in — `codicon/codicon.css` and `codicon/codicon-modifiers.css` — directly instead, mirroring the existing dynamic-CSS-import pattern already used for Katex. Both files ship in the currently pinned 0.52.2 and in newer releases, so this is behaviour-neutral today and lets the editor keep rendering its glyphs once monaco-editor is bumped past 0.52, unblocking the pending dependency update. (cherry picked from commit 2629cf3) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Aug 5, 2026
#69419) (#69422) monaco-editor 0.53 removed the `codiconStyles` side-effect module that the local ESM Monaco setup imported to register the codicon glyph font (the folding arrows and find-widget icons). Import the two stylesheets that module pulled in — `codicon/codicon.css` and `codicon/codicon-modifiers.css` — directly instead, mirroring the existing dynamic-CSS-import pattern already used for Katex. Both files ship in the currently pinned 0.52.2 and in newer releases, so this is behaviour-neutral today and lets the editor keep rendering its glyphs once monaco-editor is bumped past 0.52, unblocking the pending dependency update. (cherry picked from commit 2629cf3) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
monaco-editor0.53 removed the internalcodiconStylesside-effect module that the local ESM Monaco setup imported to register the codicon glyph font (folding arrows, find-widget icons). This imports the two stylesheets that module pulled in —codicon/codicon.cssandcodicon/codicon-modifiers.css— directly instead, mirroring the existing dynamic-CSS-import pattern already used for Katex (KatexStyleLoader.ts).Both files ship in the currently pinned
0.52.2and in newer releases, so this is behaviour-neutral today and unblocks the pendingmonaco-editorbump to 0.55.x (dependabot #69354 / the v3-3-test #69355), which otherwise fails the React UI tests with:Verified locally
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines