Raise when attaching partition keys to asset alias events - #69312
Merged
Conversation
add_partitions() validated key emptiness/length but not whether the accessor was for an asset alias, so calling it on an alias accessor silently dropped the partition key during serialization instead of attaching it to any asset event.
Lee-W
force-pushed
the
reject-alias-partition-keys
branch
from
July 3, 2026 08:52
39a94ee to
77ed97d
Compare
Lee-W
marked this pull request as ready for review
July 3, 2026 08:54
jason810496
approved these changes
Jul 7, 2026
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
add_partitions()validated key emptiness/length but never checked whether the accessor was for an asset alias.What
OutletEventAccessor.add_partitions()now raisesTypeErrorwhen the accessor's key is anAssetAliasUniqueKey, before any key processing.Was generative AI tooling used to co-author this PR?
Generated-by: [Claude] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.