Fix log line-number links highlighting - #69293
Merged
Merged
Conversation
guan404ming
requested review from
bbovenzi,
choo121600,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
July 3, 2026 03:38
guan404ming
force-pushed
the
fix-log-hash-line-mapping
branch
4 times, most recently
from
July 8, 2026 05:57
c9b811c to
9c035f9
Compare
bbovenzi
reviewed
Jul 8, 2026
bbovenzi
left a comment
bbovenzi
left a comment
Contributor
There was a problem hiding this comment.
Great!
Could we add a regression test?
guan404ming
force-pushed
the
fix-log-hash-line-mapping
branch
from
July 9, 2026 03:21
9c035f9 to
ed9479a
Compare
bbovenzi
approved these changes
Jul 9, 2026
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
bbovenzi
pushed a commit
that referenced
this pull request
Jul 9, 2026
* Fix log line-number links highlighting * Add regression test for log line-number to visible index mapping (cherry picked from commit 9dec3eb) Co-authored-by: Guan-Ming Chiu <105915352+guan404ming@users.noreply.github.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Aug 5, 2026
* Fix log line-number links highlighting * Add regression test for log line-number to visible index mapping (cherry picked from commit 9dec3eb) Co-authored-by: Guan-Ming Chiu <105915352+guan404ming@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Clicking a line-number link (or opening a URL with #N) highlighted and scrolled to the wrong log line, because the hash line number and the internal entry indexes drift apart whenever log groups or the TaskIdentity preamble are present.
How
Before
Screen.Recording.2026-07-03.at.11.37.13.AM.mov
After
Screen.Recording.2026-07-03.at.11.36.46.AM.mov
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.