preserve Gantt tooltip task end date - #68959
Closed
mralonsocorona wants to merge 2 commits into
Closed
Conversation
mralonsocorona
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
June 25, 2026 02:04
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
Member
There was a problem hiding this comment.
Thanks for the PR but unfortunately #68570 is closer to getting meerged and more complete (test cases, handling running TI logic, etc...)
Closing, feel free to re-open if I missed something.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #68174.
The Gantt timeline splits a task instance into visual segments such as scheduled, queued, and execution. For queued segments, the visual segment ends at
start_date, which is correct for rendering the queued portion of the bar.However, the tooltip summary used the visual segment end (
segment.x[1]) asmax_end_date. This caused the queued segment tooltip to show the end of the queued interval as the taskEnd Date, instead of the real task instanceend_date.What changed
end_dateon each Gantt segment asend_when.segment.end_whenfor the tooltipmax_end_datewhen available.Testing
git diff --checkcd airflow-core/src/airflow/ui && pnpm test src/layouts/Details/Gantt/utils.test.tsResult: