Skip to content

Fix UI overlap in XCom/TaskStateStore tables and Details panel - #68774

Closed
Dotify71 wants to merge 1 commit into
apache:mainfrom
Dotify71:fix/68754-ui-overlap
Closed

Fix UI overlap in XCom/TaskStateStore tables and Details panel#68774
Dotify71 wants to merge 1 commit into
apache:mainfrom
Dotify71:fix/68754-ui-overlap

Conversation

@Dotify71

@Dotify71 Dotify71 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Closes #68754

What changes did you make?

  • Updated the key columns in XCom.tsx and TaskStateStore.tsx to use the TruncatedText component. This ensures that extremely long, unbroken keys are gracefully truncated with an ellipsis and fully visible on hover (matching how run_id is handled). This prevents the table from expanding infinitely horizontally and getting cut off.
  • Adjusted the collapse button in DetailsLayout.tsx by applying transform="translateX(-100%)" (or 100% for RTL). This pulls the button into the resize handle area so it sits cleanly between the two panels rather than directly overlapping the textual content of the right panel.

Why did you make these changes?

To resolve the overlap bugs reported in #68754 and address the review feedback regarding the collapse button overlapping the right panel content.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Jun 19, 2026

@jroachgolf84 jroachgolf84 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dotify71 - please include a screenshot or video with this issue now being resolved!

@Dotify71

Dotify71 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-06-22 at 12 58 23 AM

@jroachgolf84 - Here is the screenshot verifying the issue is now resolved locally! As you can see, extremely long keys in the XCom / Task State Store tables now properly wrap to the next line instead of overlapping the UI boundaries.

Let me know if there's anything else you need before merging!

@Dotify71
Dotify71 force-pushed the fix/68754-ui-overlap branch from f3d2538 to f9d1fe1 Compare June 22, 2026 18:39
@Dotify71
Dotify71 requested a review from jroachgolf84 June 22, 2026 18:39

@jroachgolf84 jroachgolf84 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I think this was a different issue than what was originally filed. Can you share a screenshot of the issue beforehand? I'm not sure if this fixes anything?

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like untested gen AI PR, or a misunderstanding.

In your screenshot we can clearly see the bug is still happening. (the collapse drawer button still overlapping the right panel content)

Closing, feel free to re-open if you are willing to test this and make sure this actually solves the linked issue.

@Dotify71 Dotify71 changed the title Fix UI overlap for long keys in XCom and TaskStateStore tables Fix UI overlap in XCom/TaskStateStore tables and Details panel Jun 29, 2026
@Dotify71

Dotify71 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

@pierrejeambrun Thanks for the feedback! I've just created a new pr of the fixes can you check that #69114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Task State Store' or 'Xcom' key is getting overlapped with expand/collapse details panel

3 participants