Fix Grid Gantt tooltip showing wrong start date on queued/scheduled segments - #68176
Merged
bbovenzi merged 1 commit intoJun 11, 2026
Conversation
shashbha14
marked this pull request as ready for review
June 8, 2026 14:00
shashbha14
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
June 8, 2026 14:01
bbovenzi
approved these changes
Jun 8, 2026
Contributor
|
@shashbha14 Care to rebase to fix the CI? |
shashbha14
force-pushed
the
fix/gantt-tooltip-start-date-inconsistent-68174
branch
from
June 10, 2026 05:30
a285c6a to
4df3a59
Compare
Contributor
|
Thanks @shashbha14 for the fix! The Start/Queued date is now correct - but I think this catched a small regression. Now the End Date is somehow "wrong". In the queued state it shows the end date of the queueing and not the end date of the task, see: 
|
1 task
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Jun 16, 2026
…ts (apache#68176) Co-authored-by: Shashwati <shashwatibhattacaharya21.2@gmail.com>
dingo4dev
pushed a commit
to dingo4dev/airflow
that referenced
this pull request
Jun 16, 2026
…ts (apache#68176) Co-authored-by: Shashwati <shashwatibhattacaharya21.2@gmail.com>
pierrejeambrun
pushed a commit
that referenced
this pull request
Jul 2, 2026
…8570) * UI: Fix Gantt tooltip showing wrong end date on queued/scheduled bars The tooltip on the queued and scheduled segments of a Gantt bar reported the end of that segment (e.g. the moment queueing ended) as the task's End Date, instead of the task's actual end. This was a regression from the start-date fix in #68176, which made the Start Date consistent across segments but left the End Date per-segment. Carry the task's effective end (end_date, or "now" while running) on every segment of a try as `end_when`, mirroring `start_when`, and use it for the tooltip's End Date so all segments of a try report the same start and end. closes: #68174 * UI: Make end_when symmetric with start_when in Gantt tooltip data Address review: derive a single effectiveEndDate (the raw end_date, or "now" while a started task is still running) and gate end_when on it the same way start_when is gated on start_date. Finished tasks now keep the API's raw end_date string instead of a re-serialized dayjs timestamp, and the tryWhenForTooltip block no longer depends on endMs ordering. Pin the running-task test to a fixed "now" via fake timers. * UI: Remove noisy comments from Gantt tooltip data transform Address review: drop the verbose inline comments around effectiveEndDate and tryWhenForTooltip; the code is self-explanatory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #68174
The Gantt bar tooltip was showing a wrong "Start Date" when hovering over the queued part of a task. It was picking up the queued time as the start date instead of the actual execution start date. Hovering over the execution part showed the correct time.
The issue was in 'toTooltipSummary' ,it was using 'segment.x[0]' (left edge of the hovered segment) for 'min_start_date'. For the queued segment that's the queued time, not the actual start date.
Fixed by storing the real 'start_date' as 'start_when' on every 'GanttDataItem' and using that in 'toTooltipSummary' instead of 'segment.x[0]'. Now hovering any segment shows the same correct start date.
I used Claude (claude.ai) as an AI assistant for parts of this implementation.