Add stairway test for DB migrations by iting0321 · Pull Request #64905 · apache/airflow

iting0321 · 2026-04-08T13:43:30Z

Adds a test that walks every incremental Alembic migration one step at a time upgrade → downgrade → re-upgrade to verify all migrations are fully reversible.

Why:

Silent breakage can occur when a downgrade forgets to drop a constraint/column added by its upgrade, or references something that doesn't exist. The existing test_database_schema_and_sqlalchemy_model_are_in_sync only checks the final state; it won't catch a broken intermediate step.

How to test:

uv run --project airflow-core pytest airflow-core/tests/unit/migrations/test_migration_utils.py -xvs

When a step fails, the error message includes the specific revision ID so the broken migration is immediately identifiable in CI logs.

Was generative AI tooling used to co-author this PR?

Yes (please specify the tool below) Claude Code following the guidelines

jason810496

Thanks for hardening the migration test.

Copilot

Pull request overview

Adds a new “stairway” unit test intended to validate that each Alembic migration step is reversible by performing upgrade → downgrade → re-upgrade per revision, starting from the squashed baseline revision.

Changes:

Introduces a helper to enumerate migration revisions in upgrade order after the squashed base.
Adds a parametrized migration test that runs upgrade/downgrade/re-upgrade for each revision.
Attempts to reduce parallel-test DB conflicts via an xdist_group marker.

potiuk · 2026-04-09T07:51:10Z

Interesting idea. Can you please address the comments from copilot ?

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

iting0321 · 2026-04-10T04:09:53Z

Interesting idea. Can you please address the comments from copilot ?

No problem, thank you for your feedback!

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

…ine and improve DB state management

…tion handling

…etter clarity

potiuk · 2026-04-27T01:22:09Z

@iting0321 A few things need addressing before review — see our Pull Request quality criteria.

❌ Pre-commit / static checks: The Static checks job is failing. Static-check failures are deterministic and need a code fix — re-running CI won't help. Run prek run --from-ref main --stage pre-commit locally to reproduce, then push the fix.

No rush.

Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.

jason810496

Nice! LGTM for hardening the DB migration tests.

boring-cyborg · 2026-04-29T13:07:56Z

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

* add stairway tests for Airflow DB migrations to verify reversibility * refactor migration stairway test to use _REVISION_HEADS_MAP for baseline and improve DB state management * refactor stairway test to start from 3.0.0 revision and improve migration handling * refactor stairway test failure handling to raise AssertionError for better clarity * fix: add space in return statement for consistency in revision order --------- Co-authored-by: iting0321 <iting0321@MacBook-11111156.local>

* add stairway tests for Airflow DB migrations to verify reversibility * refactor migration stairway test to use _REVISION_HEADS_MAP for baseline and improve DB state management * refactor stairway test to start from 3.0.0 revision and improve migration handling * refactor stairway test failure handling to raise AssertionError for better clarity * fix: add space in return statement for consistency in revision order --------- (cherry picked from commit 8a6a79f) Co-authored-by: iting0321 <137410100+iting0321@users.noreply.github.com> Co-authored-by: iting0321 <iting0321@MacBook-11111156.local>

jason810496 reviewed Apr 9, 2026

View reviewed changes

Comment thread airflow-core/tests/unit/migrations/test_migration_utils.py Outdated

Comment thread airflow-core/tests/unit/migrations/test_migration_utils.py Outdated

jason810496 requested a review from Copilot April 9, 2026 01:41

Copilot started reviewing on behalf of jason810496 April 9, 2026 01:42 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

jason810496 requested a review from Copilot April 9, 2026 09:31

Copilot AI reviewed Apr 9, 2026

View reviewed changes

kaxil requested a review from Copilot April 10, 2026 19:55

Copilot AI reviewed Apr 10, 2026

View reviewed changes

Comment thread airflow-core/tests/unit/migrations/test_migration_utils.py Outdated

jason810496 requested a review from Copilot April 11, 2026 08:00

Copilot started reviewing on behalf of jason810496 April 11, 2026 08:00 View session

Copilot AI reviewed Apr 11, 2026

View reviewed changes

Comment thread airflow-core/tests/unit/migrations/test_migration_utils.py

iting0321 added 4 commits April 20, 2026 09:28

add stairway tests for Airflow DB migrations to verify reversibility

988fd6e

refactor migration stairway test to use _REVISION_HEADS_MAP for basel…

2011cf7

…ine and improve DB state management

refactor stairway test to start from 3.0.0 revision and improve migra…

fada846

…tion handling

refactor stairway test failure handling to raise AssertionError for b…

ff0ab6d

…etter clarity

jason810496 force-pushed the stairway-test branch from 67cb6a8 to ff0ab6d Compare April 20, 2026 01:28

fix: add space in return statement for consistency in revision order

23c33b1

jason810496 approved these changes Apr 29, 2026

View reviewed changes

jason810496 merged commit 8a6a79f into apache:main Apr 29, 2026
77 checks passed

jason810496 mentioned this pull request Apr 30, 2026

Fix flaky test_migration_stairway by retrying each migration step #66162

Merged

1 task

jason810496 added the backport-to-v3-2-test label May 2, 2026

jason810496 added this to the Airflow 3.2.2 milestone May 2, 2026

Uh oh!

Conversation

iting0321 commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why:

How to test:

Uh oh!

jason810496 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

potiuk commented Apr 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iting0321 commented Apr 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

potiuk commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jason810496 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

boring-cyborg Bot commented Apr 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iting0321 commented Apr 8, 2026 •

edited

Loading

potiuk commented Apr 27, 2026 •

edited

Loading