Add Amazon Provider Neptune Analytics - #64274
Conversation
|
Hey @ellisms, thanks for working on this one! |
|
@ellisms Converting to draft — this PR doesn't yet meet our Pull Request quality criteria.
See the linked criteria for how to fix each item, then mark the PR "Ready for review". This is not a rejection — just an invitation to bring the PR up to standard. No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
|
Odd, all my prek checks passed locally and I rebased before pushing. Will check it out and fix. |
There was a problem hiding this comment.
Pull request overview
This PR adds Amazon Neptune Analytics support to the providers/amazon package, introducing new operators and deferrable triggers (plus unit tests) to manage Neptune Analytics graphs, private endpoints, and import tasks.
Changes:
- Add unit test coverage for Neptune Analytics waiter-based triggers.
- Add extensive unit test coverage for new Neptune Analytics operators (create/delete graph, private endpoints, import tasks, deferrable behaviors).
- Implement Neptune Analytics operators (including async/deferrable completion paths).
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 17 comments.
| File | Description |
|---|---|
| providers/amazon/src/airflow/providers/amazon/aws/operators/neptune_analytics.py | Adds Neptune Analytics operator implementations; includes deferrable execute_complete paths. |
| providers/amazon/tests/unit/amazon/aws/operators/test_neptune_analytics.py | Adds unit tests for Neptune Analytics operators (sync + deferrable modes, error paths). |
| providers/amazon/tests/unit/amazon/aws/triggers/test_neptune_analytics.py | Adds unit tests for Neptune Analytics triggers (serialization + async waiter success/failure). |
d2999c0 to
4758d76
Compare
|
@o-nikolas I think all issues are resolved. |
shivaam
left a comment
There was a problem hiding this comment.
Hello,
Thank you for adding a provider for neptune analytics. I was able to successfully run the example dag but hit some issues in cleanup. I have posted a few other comments as well.
0b8ce2b to
42cb361
Compare
|
@ellisms Converting to draft — this PR doesn't yet meet our Pull Request quality criteria.
See the linked criteria for how to fix each item, then mark the PR "Ready for review". This is not a rejection — just an invitation to bring the PR up to standard. No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. |
…nalytics.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ptune_analytics.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
23f0a70 to
3b8b22c
Compare
|
Resolved conflicts, tested and resolved deferrable issues. |
o-nikolas
left a comment
There was a problem hiding this comment.
Looks good to me, as long as the tests go green
closes: #60975
Added Neptune Analytics operators to create and delete graphs, create and delete private endpoints, and create/cancel import tasks.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.