Skip to content

Fix newline rendering in DAG warning alert UI - #63588

Merged
pierrejeambrun merged 3 commits into
apache:mainfrom
wjddn279:fix-dag-warning-ui-newline
Mar 20, 2026
Merged

Fix newline rendering in DAG warning alert UI#63588
pierrejeambrun merged 3 commits into
apache:mainfrom
wjddn279:fix-dag-warning-ui-newline

Conversation

@wjddn279

Copy link
Copy Markdown
Contributor

related: #59430

Description

Fixes an issue where newlines (\n) in the message field of the DAG warning API were not being rendered as line breaks in the UI.

UI

ASIS

image

TOBE

image
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Mar 14, 2026
Comment thread airflow-core/src/airflow/ui/src/components/WarningAlert.tsx Outdated

@shivaam shivaam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor nit on whitespace consistency with ErrorAlert, but overall LGTM. Clean fix.

@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Mar 16, 2026

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to adjust a small thing and looking good.

Comment thread airflow-core/src/airflow/ui/src/components/WarningAlert.tsx Outdated
@wjddn279
wjddn279 force-pushed the fix-dag-warning-ui-newline branch from a4ff609 to 938caab Compare March 19, 2026 08:16
@wjddn279

Copy link
Copy Markdown
Contributor Author

@shivaam @pierrejeambrun

thanks for review and suggestion!! I've applied it!

Comment thread airflow-core/src/airflow/ui/src/components/WarningAlert.tsx Outdated
@wjddn279
wjddn279 force-pushed the fix-dag-warning-ui-newline branch from 938caab to 7d7ff06 Compare March 19, 2026 14:00

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pierrejeambrun pierrejeambrun self-assigned this Mar 20, 2026
@pierrejeambrun pierrejeambrun added this to the Airflow 3.2.0 milestone Mar 20, 2026
@pierrejeambrun
pierrejeambrun merged commit 9147e79 into apache:main Mar 20, 2026
81 checks passed
fat-catTW pushed a commit to fat-catTW/airflow that referenced this pull request Mar 22, 2026
* fix dag warning alert UI to display newline

* fix css

* fix css
Suraj-kumar00 pushed a commit to Suraj-kumar00/airflow that referenced this pull request Apr 7, 2026
* fix dag warning alert UI to display newline

* fix css

* fix css
abhijeets25012-tech pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Apr 9, 2026
* fix dag warning alert UI to display newline

* fix css

* fix css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants