Skip to content

Add shutdown-all-workers command to Edge CLI - #55626

Merged
jscheffl merged 2 commits into
apache:mainfrom
dheerajturaga:feature/edge-shutdown-all-workers
Sep 13, 2025
Merged

Add shutdown-all-workers command to Edge CLI#55626
jscheffl merged 2 commits into
apache:mainfrom
dheerajturaga:feature/edge-shutdown-all-workers

Conversation

@dheerajturaga

@dheerajturaga dheerajturaga commented Sep 13, 2025

Copy link
Copy Markdown
Member

Implement new Edge CLI command to gracefully shutdown all registered edge workers with confirmation prompt. Command follows similar pattern to celery shutdown-all-workers, requiring user confirmation with y/n prompt unless bypassed with --yes flag.

image

cc: @jscheffl

  Implement new Edge CLI command to gracefully shutdown all registered edge workers with confirmation prompt. Command follows similar
  pattern to celery shutdown-all-workers, requiring user confirmation with y/n prompt unless bypassed with --yes flag.
@boring-cyborg boring-cyborg Bot added area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3 labels Sep 13, 2025

@jscheffl jscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature. Looks good in general. Might be OK to merge, just 2 comments... but both are non blocking.

Comment thread providers/edge3/src/airflow/providers/edge3/cli/edge_command.py
Comment thread providers/edge3/src/airflow/providers/edge3/cli/edge_command.py
@jscheffl

Copy link
Copy Markdown
Contributor

Forgot to mention: Can you please also adjust RST docs for the maintenance commands to be consistent?

@dheerajturaga
dheerajturaga force-pushed the feature/edge-shutdown-all-workers branch from 4baaf4f to 34029b8 Compare September 13, 2025 17:23
@jscheffl
jscheffl merged commit 2ed106c into apache:main Sep 13, 2025
74 checks passed
suman-himanshu pushed a commit to suman-himanshu/airflow that referenced this pull request Sep 17, 2025
* Add shutdown-all-workers command to Edge CLI

  Implement new Edge CLI command to gracefully shutdown all registered edge workers with confirmation prompt. Command follows similar
  pattern to celery shutdown-all-workers, requiring user confirmation with y/n prompt unless bypassed with --yes flag.

* Doc update
Brunda10 pushed a commit to Brunda10/airflow that referenced this pull request Sep 17, 2025
* Add shutdown-all-workers command to Edge CLI

  Implement new Edge CLI command to gracefully shutdown all registered edge workers with confirmation prompt. Command follows similar
  pattern to celery shutdown-all-workers, requiring user confirmation with y/n prompt unless bypassed with --yes flag.

* Doc update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants