Change pre-commit propety(v1) - #53636
Conversation
|
What problem does it solve really ? |
|
I realized that while I updated the API, I missed the corresponding frontend changes. Unfortunately, I wasn't able to reproduce the issue on my side, but I should have been more careful before submitting the PR. I sincerely apologize for the oversight. I’ll make the necessary adjustments and prepare an updated version for review soon. I also want to acknowledge that I didn’t fully consider how valuable your time as a reviewer is—I'm truly sorry for that. |
No worries - I was just wondering what's wrong there :) |
The current so it doesn't catch changes like to ensure all OpenAPI changes under the There is an issue with the pre-commit scope, which is causing the following failure: https://github.com/apache/airflow/actions/runs/16489362751/job/46620971120 |
b5890a3 to
69a1daf
Compare
69a1daf to
7712f5c
Compare
7712f5c to
5774ab6
Compare
|
Cool |
|
Now it makes sense :) |
(cherry picked from commit 9d9924e) Co-authored-by: Kyungjun Lee <kyungjunlee.me@gmail.com>
Backport successfully created: v3-0-test
|
apache#68919 changed _private_ui.yaml without regenerating the TypeScript client and CI stayed green: selective checks decide whether to skip the ts-compile-lint-* hooks from file groups that do not cover the UI codegen input specs, while the hooks themselves trigger on any yaml under the openapi directories. The stale client then masked a type error that broke main for every PR running full static checks. The same gap applied to v2-simple-auth-manager-generated.yaml, so a spec-only change also skipped the simple auth manager UI hook. Track the codegen-input specs in their own file group so spec-only changes run the UI hooks without forcing the full test matrix, and drop the main UI hook trigger for the simple auth manager spec: that pattern was copied in when the hook was created (apache#51725), a month after the spec was renamed v1 to v2 (apache#50705), so it has never matched a file - apache#53636 fixed the sibling hook's copy but missed this one. The main UI codegen does not consume that spec either.
#68919 changed _private_ui.yaml without regenerating the TypeScript client and CI stayed green: selective checks decide whether to skip the ts-compile-lint-* hooks from file groups that do not cover the UI codegen input specs, while the hooks themselves trigger on any yaml under the openapi directories. The stale client then masked a type error that broke main for every PR running full static checks. The same gap applied to v2-simple-auth-manager-generated.yaml, so a spec-only change also skipped the simple auth manager UI hook. Track the codegen-input specs in their own file group so spec-only changes run the UI hooks without forcing the full test matrix, and drop the main UI hook trigger for the simple auth manager spec: that pattern was copied in when the hook was created (#51725), a month after the spec was renamed v1 to v2 (#50705), so it has never matched a file - #53636 fixed the sibling hook's copy but missed this one. The main UI codegen does not consume that spec either.
…nges (#70643) #68919 changed _private_ui.yaml without regenerating the TypeScript client and CI stayed green: selective checks decide whether to skip the ts-compile-lint-* hooks from file groups that do not cover the UI codegen input specs, while the hooks themselves trigger on any yaml under the openapi directories. The stale client then masked a type error that broke main for every PR running full static checks. The same gap applied to v2-simple-auth-manager-generated.yaml, so a spec-only change also skipped the simple auth manager UI hook. Track the codegen-input specs in their own file group so spec-only changes run the UI hooks without forcing the full test matrix, and drop the main UI hook trigger for the simple auth manager spec: that pattern was copied in when the hook was created (#51725), a month after the spec was renamed v1 to v2 (#50705), so it has never matched a file - #53636 fixed the sibling hook's copy but missed this one. The main UI codegen does not consume that spec either. (cherry picked from commit b43a87e) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
2 participants
it solve ci error in github.
related #53597
It cause error. refer to below image.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.