Skip to content

AIP-68 Add loading validation to React App and External Views - #52972

Merged
pierrejeambrun merged 2 commits into
apache:mainfrom
astronomer:aip-68-add-loading-validation-to-ui-plugins
Jul 9, 2025
Merged

AIP-68 Add loading validation to React App and External Views#52972
pierrejeambrun merged 2 commits into
apache:mainfrom
astronomer:aip-68-add-loading-validation-to-ui-plugins

Conversation

@pierrejeambrun

@pierrejeambrun pierrejeambrun commented Jul 7, 2025

Copy link
Copy Markdown
Member

Example of conflicting views / apps within the same plugi:n
Screenshot 2025-07-07 at 11 33 58

Comment thread airflow-core/src/airflow/api_fastapi/app.py
@pierrejeambrun pierrejeambrun added the log exception Set the label if you want to accept change with caplog label Jul 7, 2025
@pierrejeambrun

pierrejeambrun commented Jul 7, 2025

Copy link
Copy Markdown
Member Author

Setting log exception label because this is the same pattern of other tests in the very same file.

@bugraoz93 bugraoz93 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Small comment related to caplog which failing on the CI

Comment thread airflow-core/tests/unit/plugins/test_plugins_manager.py
@pierrejeambrun
pierrejeambrun merged commit 0a047bd into apache:main Jul 9, 2025
165 of 167 checks passed
@pierrejeambrun
pierrejeambrun deleted the aip-68-add-loading-validation-to-ui-plugins branch July 9, 2025 14:37
HsiuChuanHsu pushed a commit to HsiuChuanHsu/airflow that referenced this pull request Jul 10, 2025
…#52972)

* AIP-68 Add loading validation to React App and External Views

* Small adjustment
stephen-bracken pushed a commit to stephen-bracken/airflow that referenced this pull request Jul 15, 2025
…#52972)

* AIP-68 Add loading validation to React App and External Views

* Small adjustment
@jscheffl jscheffl added the AIP-68 Extended Plugin Interface for React Views label Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AIP-68 Extended Plugin Interface for React Views area:API Airflow's REST/HTTP API area:plugins log exception Set the label if you want to accept change with caplog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants