Remove unused batch methods from auth manager - #52883
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:API
vincbeck
force-pushed
the
vincbeck/remove_batch
branch
from
July 4, 2025 15:57
d7d1f6b to
c3141eb
Compare
o-nikolas
approved these changes
Jul 4, 2025
o-nikolas
left a comment
o-nikolas
left a comment
Contributor
There was a problem hiding this comment.
Code changes LGTM
Will this part of the interface never be used in the future? If so, we plan to just add it back?
Contributor
Author
It is always hard to anticipate needs but I do not think we'll need it. And if so, we can always add it back. These methods are not abstract methods, so adding them back is not a breaking change |
vincbeck
force-pushed
the
vincbeck/remove_batch
branch
from
July 7, 2025 14:59
c3141eb to
a5347e9
Compare
17 tasks
HsiuChuanHsu
pushed a commit
to HsiuChuanHsu/airflow
that referenced
this pull request
Jul 10, 2025
stephen-bracken
pushed a commit
to stephen-bracken/airflow
that referenced
this pull request
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove methods
batch_is_authorized_connection,batch_is_authorized_poolandbatch_is_authorized_variablefrom auth manager interface (and underlying concrete implementations) since they are no longer used.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.