Updated msgraph-core and kiota libraries - #48589
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:microsoft-azure
2 tasks
dabla
marked this pull request as draft
April 1, 2025 05:52
Contributor
|
Tests are failing |
Contributor
Author
Yes I know I'm going to try finish this one today |
dabla
marked this pull request as ready for review
April 4, 2025 13:15
dabla
requested review from
ashb,
gopidesupavan,
jedcunningham and
potiuk
as code owners
April 4, 2025 13:15
Contributor
Author
|
Almost there I think, just some weird failure with static checks |
Contributor
|
There are additional files in the PR due to permission changes. These files were previously marked as executables but no longer are. |
Contributor
Author
Weird how did those files get in there, hmm I see it's from rebase |
refactor: Replace ResponseType with str refactor: Reorganized imports TestKiotaRequestAdapterHook refactor: Updated dependencies in README refactor: Moved some imports to type checking block refactor: Changed cast statements in assert_tenant_id method refactor: Added cast for credentials in asert_tenant_id refactor: Replaced QueryParameters type with Any refactor: Fixed casting in assert_tenant_id method refactor: Ignore type errors for error_mapping refactor: Assigned casted response to new resp variable refactor: Refactored casting statements in assert_tenant_id method refactor: Refactored cast of Response in get_value method refactor: Updated dependencies in get_provider_info refactor: Deleted provider_dependencies.json refactor: cast types in assert_tenant_id method refactor: Recast response to httpx Response refactor: Introduced send_request method in KiotaRequestAdapterHook refactor: Changed return type of error_mapping method refactor: check data type in request_information method refactor: cast NativeResponseType to httpx.Response before passing it to get_value method refactor: error_map cannot be None by default as this would not correspond with abstract method signature of ResponseHandler refactor: Reformatted TestKiotaRequestAdapterHook refactor: response parameter can be NativeResponseType as httpx Response in get_value refactor: Fixed type casting in assert_tenant_id
dabla
force-pushed
the
fix/msgraph-kiota-dependency
branch
from
April 4, 2025 16:34
45ca792 to
b38a677
Compare
# Conflicts: # providers/microsoft/azure/README.rst # providers/microsoft/azure/pyproject.toml # providers/microsoft/azure/src/airflow/providers/microsoft/azure/get_provider_info.py
eladkal
approved these changes
Apr 5, 2025
diogotrodrigues
pushed a commit
to diogotrodrigues/airflow
that referenced
this pull request
Apr 6, 2025
* refactor: Updated msgraph-core and kiota library versions to at least version 1.8.0 * refactor: await send_request refactor: Replace ResponseType with str refactor: Reorganized imports TestKiotaRequestAdapterHook refactor: Updated dependencies in README refactor: Moved some imports to type checking block refactor: Changed cast statements in assert_tenant_id method refactor: Added cast for credentials in asert_tenant_id refactor: Replaced QueryParameters type with Any refactor: Fixed casting in assert_tenant_id method refactor: Ignore type errors for error_mapping refactor: Assigned casted response to new resp variable refactor: Refactored casting statements in assert_tenant_id method refactor: Refactored cast of Response in get_value method refactor: Updated dependencies in get_provider_info refactor: Deleted provider_dependencies.json refactor: cast types in assert_tenant_id method refactor: Recast response to httpx Response refactor: Introduced send_request method in KiotaRequestAdapterHook refactor: Changed return type of error_mapping method refactor: check data type in request_information method refactor: cast NativeResponseType to httpx.Response before passing it to get_value method refactor: error_map cannot be None by default as this would not correspond with abstract method signature of ResponseHandler refactor: Reformatted TestKiotaRequestAdapterHook refactor: response parameter can be NativeResponseType as httpx Response in get_value refactor: Fixed type casting in assert_tenant_id --------- Co-authored-by: David Blain <david.blain@infrabel.be>
Member
|
Nice one @dabla ;) |
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
* refactor: Updated msgraph-core and kiota library versions to at least version 1.8.0 * refactor: await send_request refactor: Replace ResponseType with str refactor: Reorganized imports TestKiotaRequestAdapterHook refactor: Updated dependencies in README refactor: Moved some imports to type checking block refactor: Changed cast statements in assert_tenant_id method refactor: Added cast for credentials in asert_tenant_id refactor: Replaced QueryParameters type with Any refactor: Fixed casting in assert_tenant_id method refactor: Ignore type errors for error_mapping refactor: Assigned casted response to new resp variable refactor: Refactored casting statements in assert_tenant_id method refactor: Refactored cast of Response in get_value method refactor: Updated dependencies in get_provider_info refactor: Deleted provider_dependencies.json refactor: cast types in assert_tenant_id method refactor: Recast response to httpx Response refactor: Introduced send_request method in KiotaRequestAdapterHook refactor: Changed return type of error_mapping method refactor: check data type in request_information method refactor: cast NativeResponseType to httpx.Response before passing it to get_value method refactor: error_map cannot be None by default as this would not correspond with abstract method signature of ResponseHandler refactor: Reformatted TestKiotaRequestAdapterHook refactor: response parameter can be NativeResponseType as httpx Response in get_value refactor: Fixed type casting in assert_tenant_id --------- Co-authored-by: David Blain <david.blain@infrabel.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.