Skip to content

Fix asset materialize CLI command - #48391

Closed
vatsrahul1001 wants to merge 2 commits into
apache:mainfrom
astronomer:fix-asset-materialize-command
Closed

Fix asset materialize CLI command#48391
vatsrahul1001 wants to merge 2 commits into
apache:mainfrom
astronomer:fix-asset-materialize-command

Conversation

@vatsrahul1001

Copy link
Copy Markdown
Contributor

closes: #48382


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Lee-W Lee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering whether there's a way to test this 🤔

name="materialize",
help="Materialize an asset",
func=lazy_load_command("airflow.cli.commands.asset_command.asset_materialize"),
func=lazy_load_command("airflow.cli.commands.remote_commands.asset_command.asset_materialize"),

@bugraoz93 bugraoz93 Mar 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now flat in airflow-core, where all commands are under airflow-core/cli/commands. It was before like this remote_commands and local_commands. Now the split is more on airflowctl containing remote and airflow containing local commands. Everything is moved in here: #48224. Let me check too

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh didn't notice it. I guess that means we probably don't need this one? @vatsrahul1001 could you please test it out and see whether it works well in main already? Thanks!

@bugraoz93

Copy link
Copy Markdown
Contributor

Seems like it is fixed in the main. Please correct me if I missed something
Screenshot from 2025-03-26 18-35-16
... providers_manager Logs
Screenshot from 2025-03-26 18-35-25

@jedcunningham jedcunningham left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we should be good to go without this now - working for me too. Thanks for the PR though @vatsrahul1001.

@jedcunningham
jedcunningham deleted the fix-asset-materialize-command branch March 27, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not able to materialize an asset via CLI

4 participants