Skip to content

Add do_xcom_push documentation in EcsRunTaskOperator - #44440

Merged
potiuk merged 2 commits into
apache:mainfrom
leonidasefrem:patch-1
Nov 28, 2024
Merged

Add do_xcom_push documentation in EcsRunTaskOperator#44440
potiuk merged 2 commits into
apache:mainfrom
leonidasefrem:patch-1

Conversation

@leonidasefrem

Copy link
Copy Markdown
Contributor

Adding documentation for the do_xcom_push parameter in the EcsRunTaskOperator. This parameter pushes the ECS task ARN into XCom, and if AWS CloudWatch logs are fetched, it also adds the last log message to XCom with the key 'return_value'

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

leonidasefrem and others added 2 commits November 27, 2024 22:45
Adding documentation for the do_xcom_push parameter in the EcsRunTaskOperator. This parameter pushes the ECS task ARN into XCom, and if AWS CloudWatch logs are fetched, it also adds the last log message to XCom with the key 'return_value'
@boring-cyborg

boring-cyborg Bot commented Nov 28, 2024

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk changed the title Add do_xcom_push in EcsRunTaskOperator Add do_xcom_push documentation in EcsRunTaskOperator Nov 28, 2024
@potiuk
potiuk merged commit 933e3ce into apache:main Nov 28, 2024
@boring-cyborg

boring-cyborg Bot commented Nov 28, 2024

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

prabhusneha pushed a commit to astronomer/airflow that referenced this pull request Nov 28, 2024
* Add do_xcom_push in EcsRunTaskOperator 

Adding documentation for the do_xcom_push parameter in the EcsRunTaskOperator. This parameter pushes the ECS task ARN into XCom, and if AWS CloudWatch logs are fetched, it also adds the last log message to XCom with the key 'return_value'

* aling text
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
* Add do_xcom_push in EcsRunTaskOperator 

Adding documentation for the do_xcom_push parameter in the EcsRunTaskOperator. This parameter pushes the ECS task ARN into XCom, and if AWS CloudWatch logs are fetched, it also adds the last log message to XCom with the key 'return_value'

* aling text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants