Add fail_on_file_not_exist option to SFTPToS3Operator - #44320
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
2 tasks
Guaqamole
force-pushed
the
AIRFLOW-40576
branch
from
November 25, 2024 15:31
ae25482 to
2984be7
Compare
ephraimbuddy
approved these changes
Nov 25, 2024
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
vincbeck
reviewed
Nov 26, 2024
ferruzzi
approved these changes
Nov 27, 2024
potiuk
approved these changes
Nov 27, 2024
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Nov 28, 2024
* Add fail_on_file_not_exist option to SFTPToS3Operator * Fixed test for fail_on_file_not_exist option. * �Remove else condition with fail_on_file_not exist option Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> --------- Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
* Add fail_on_file_not_exist option to SFTPToS3Operator * Fixed test for fail_on_file_not_exist option. * �Remove else condition with fail_on_file_not exist option Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> --------- Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #40576
I added
fail_on_file_not_existparam toSFTPToS3Operatorso that user can configure the parameter and operator will not fail in case of sftp file not exist.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.Here's the test result ran in my local environment.

you can see the dag does not fail with
fail_on_file_not_existbut still shows logs that the file does not exist.sftp_to_s3_dag.py