FIX add error_cb to confluent.Consumer config in ConsumerFromTopic - #44307
Merged
Conversation
rawwar
self-requested a review
November 23, 2024 14:14
rawwar
reviewed
Nov 23, 2024
rawwar
reviewed
Nov 23, 2024
rawwar
left a comment
rawwar
left a comment
Contributor
There was a problem hiding this comment.
I think, the approach looks good and similar to what I have tested. Please update tests.
mrk-andreev
reviewed
Nov 24, 2024
mrk-andreev
reviewed
Dec 3, 2024
potiuk
reviewed
Dec 6, 2024
potiuk
approved these changes
Dec 8, 2024
Contributor
Author
|
Thanks for the review |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #43569