Use S3CopyObjectOperator in example_comprehend_document_classifier - #44160
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:amazon
ferruzzi
approved these changes
Nov 18, 2024
ferruzzi
left a comment
ferruzzi
left a comment
Contributor
There was a problem hiding this comment.
Left a non-blocking thought, otherwise I think it makes sense.
vincbeck
force-pushed
the
vincbeck/comprehend
branch
from
November 18, 2024 21:34
83d97b6 to
c6b5eb6
Compare
eladkal
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, the system test
example_comprehend_document_classifierdownloads 10 times the same file from Github and save it in s3. As a consequence, Github might block you access and return a 403. Let's be nice with Github and download it once and then copy it from s3 to s3^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.