spark-submit: replace principle by principal - #44150
Merged
eladkal merged 6 commits intoNov 19, 2024
Merged
Conversation
This is related to apache#43679, in which the `airflow.security.kerberos.get_kerberos_principle` function was renamed `get_kerberos_principle`. In this patch, we introduce a `try/except` block around this import, getting ready to deprecate the typo-ed function in Airflow 3.0. We also fix a innocuous typo in a unit test. Signed-off-by: Balthazar Rouberol <brouberol@wikimedia.org>
eladkal
approved these changes
Nov 18, 2024
eladkal
reviewed
Nov 18, 2024
shahar1
reviewed
Nov 18, 2024
shahar1
left a comment
shahar1
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. Static checks currently fail.
eladkal
reviewed
Nov 19, 2024
Contributor
Author
|
Sorry, I was afk for a bit. Thanks for taking care of the fixes! |
romsharon98
reviewed
Nov 19, 2024
eladkal
reviewed
Nov 19, 2024
romsharon98
reviewed
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #43679, in which the
airflow.security.kerberos.get_kerberos_principlefunction was renamedget_kerberos_principle.In this patch, we introduce a
try/exceptblock around this import, getting ready to deprecate the typo-ed function in Airflow 3.0.We also fix a innocuous typo in a unit test.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.