Make host/port configurable for Snowflake connections - #44079
Merged
Conversation
whummer
marked this pull request as ready for review
November 15, 2024 23:23
potiuk
approved these changes
Nov 16, 2024
potiuk
left a comment
Member
There was a problem hiding this comment.
For that kind of change tests are not needed (other than testing when we release it)
kandharvishnu
pushed a commit
to kandharvishnu/airflow
that referenced
this pull request
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all - thanks so much for building Airflow, it is an absolutely awesome platform! 🙌 🚀
This PR extends the functionality of
SnowflakeHookto make the host/port configurable for Snowflake connections. This facilitates testing against non-standard Snowflake endpoints, for example when testing against LocalStack (a local cloud emulator).A similar PR has been created against the Astronomer Cosmos repo some time ago (see astronomer/astronomer-cosmos#1063), and our users have now requested to use the standard Airflow Snowflake connector with LocalStack Snowflake as well.
The PR also updates the documentation for the Snowflake connector, but it does not contain any tests at this point. If adding a test is required, then any pointers or guidance would be appreciated. 👍
Testing
Tested this locally against the LocalStack Snowflake emulator - with a connection config like this:
... and a simple DAG like this:
... the DAG executes successfully, and outputs:

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.