Bump aiohttp to 3.11.1 - #44036
Merged
Merged
Conversation
vincbeck
approved these changes
Nov 14, 2024
Member
Author
|
pnuckowski/aioresponses#262 hasn't been merged yet though |
Member
It's unllikely to be merged - the maintainer seems to be MIA for 2 years. That's why likely aiohttp brought back compatiblity with released version of the aioresponses as it is popular |
potiuk
reviewed
Nov 14, 2024
kaxil
commented
Nov 14, 2024
potiuk
approved these changes
Nov 14, 2024
Member
|
looks good. Maybe one nit - would be great to add comment with link to the issue in provider.yaml |
Member
|
(we have it in commit so no strictly necessary - but it safes git blame etc.) |
kaxil
commented
Nov 14, 2024
Member
Author
Done |
potiuk
approved these changes
Nov 14, 2024
Bump `aiohttp` to `3.11.1` aio-libs/aiohttp#9866 was fixed by pnuckowski/aioresponses#262 (comment) https://pypi.org/project/aiohttp/3.11.1/
jscheffl
approved these changes
Nov 14, 2024
Member
Author
|
Damn! last commit msg was used as commit title :( |
Member
|
Good we have the comment :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aio-libs/aiohttp#9866 was fixed by pnuckowski/aioresponses#262 (comment)
https://pypi.org/project/aiohttp/3.11.1/
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.