Skip to content

DOC fix documentation error in apache-airflow-providers-fab/access-control.rst - #43495

Merged
eladkal merged 2 commits into
apache:mainfrom
SuccessMoses:fix-provider-fab-doc
Oct 31, 2024
Merged

DOC fix documentation error in apache-airflow-providers-fab/access-control.rst#43495
eladkal merged 2 commits into
apache:mainfrom
SuccessMoses:fix-provider-fab-doc

Conversation

@SuccessMoses

@SuccessMoses SuccessMoses commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

closes: #43140

@boring-cyborg

boring-cyborg Bot commented Oct 29, 2024

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@SuccessMoses

Copy link
Copy Markdown
Contributor Author

Congratulations on your first Pull Request and welcome to the Apache Airflow community!

Thanks boring-cyborg

@potiuk

potiuk commented Oct 30, 2024

Copy link
Copy Markdown
Member

I think you have a space missing and Sphix does not like it when formatting tables.

Comment thread docs/apache-airflow-providers-fab/auth-manager/access-control.rst Outdated
@eladkal
eladkal merged commit db4afd7 into apache:main Oct 31, 2024
@boring-cyborg

boring-cyborg Bot commented Oct 31, 2024

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@SuccessMoses
SuccessMoses deleted the fix-provider-fab-doc branch November 11, 2024 20:19
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
…ontrol.rst` (apache#43495)

* fix doc error for provider fab

* Update docs/apache-airflow-providers-fab/auth-manager/access-control.rst

---------

Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DAG-level permissions for /dags/{dag_id}/clearTaskInstances is incorrect

4 participants