Add Trigger DAG UI with advance options - #43367
Merged
Merged
Conversation
Contributor
Author
|
@jscheffl Tried to cover many points. Still some points left.
|
jscheffl
reviewed
Oct 24, 2024
jscheffl
left a comment
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Some early bird comments - mostly beautifying and details. Don't take all of them too serious, rather as hints.
shubhamraj-git
force-pushed
the
trigger-ui
branch
from
October 26, 2024 20:55
98d83cf to
042947b
Compare
bbovenzi
reviewed
Oct 29, 2024
bbovenzi
reviewed
Oct 29, 2024
bbovenzi
reviewed
Oct 29, 2024
bbovenzi
left a comment
bbovenzi
left a comment
Contributor
There was a problem hiding this comment.
Let's move this from inside components/DataTable to components/TriggerDag
shubhamraj-git
force-pushed
the
trigger-ui
branch
from
November 2, 2024 18:14
2fad497 to
e910c44
Compare
Contributor
|
Oh you already rebased? How was moving your changes to chakra v3? |
Contributor
Author
|
@bbovenzi |
Contributor
|
Ok. Let me know if you want me to pull the branch down and help with the rebase. |
shubhamraj-git
force-pushed
the
trigger-ui
branch
from
November 4, 2024 19:22
e910c44 to
a9104d6
Compare
Contributor
Author
jscheffl
reviewed
Nov 10, 2024
jscheffl
left a comment
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Just one small bug and a small nit... otherwise looks very good and from my point could be merged!
Thanks!
bbovenzi
reviewed
Nov 11, 2024
bbovenzi
reviewed
Nov 11, 2024
bbovenzi
reviewed
Nov 11, 2024
bbovenzi
reviewed
Nov 11, 2024
bbovenzi
reviewed
Nov 11, 2024
shubhamraj-git
changed the title
bbovenzi
reviewed
Nov 12, 2024
bbovenzi
approved these changes
Nov 13, 2024
bbovenzi
left a comment
bbovenzi
left a comment
Contributor
There was a problem hiding this comment.
Great work! Thanks for being patient with all the back-and-forth review comments.
Contributor
+1 from my side for handling all the comments :-D |
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Nov 14, 2024
* Initial draft * some modifications * rectifications * initial react hook * reset only on form change * moving to diff componnent * upgrading chakra ui 3.0 for TriggerDagForm.tsx * upgrading chakra ui 3.0 for TriggerDagModal.tsx * fix lint * fix css * add close * dynamic theme for json * lint fix * simplify reset * reviews * json validation * remove color schema * use accordion * Add Accordion component * Use accordion component in triggeer form * remove dag id from title * fix response tracking * add blue button * making diff components for diff buttons * lints * lints fix * variant add * reset the form on close * change type to string * optimise * post input validation and pretiffy for json * modal refactor * reviews * add fiplay button * replace logical with data interval * add dag pause-upause toggle * enable trigger for pause dag * refactor * DAG --------- Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.