Validate aws service exceptions in waiters - #41941
Merged
vincbeck merged 1 commit intoSep 4, 2024
Merged
Conversation
boring-cyborg
Bot
added
area:providers
provider:amazon
gopidesupavan
marked this pull request as draft
September 2, 2024 00:31
gopidesupavan
marked this pull request as ready for review
September 2, 2024 17:45
vincbeck
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #41918
At present, we lack validation for some common AWS errors.
For common Step Function errors, refer to this link:
https://docs.aws.amazon.com/step-functions/latest/apireference/CommonErrors.html
Other AWS services may have additional common errors.
When a waiter encounters an error response from API calls, the waiter model in botocore generates a waiter error, as shown here:
https://github.com/boto/botocore/blob/develop/botocore/waiter.py#L361
This PR aims to capture such errors in the async_wait and wait methods.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.